Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix failing airbyte-ci-install (related to ubuntu-latest image no longer compatible with airbyte-ci binaries) #50992

Merged
merged 10 commits into from
Jan 8, 2025

Conversation

ChristoGrab
Copy link
Contributor

@ChristoGrab ChristoGrab commented Jan 8, 2025

What

Our CI workflows were using worker definitions that were based on ubuntu-latest, even though in the code there was no reference to ubuntu-latest in the workflow itself.

The problem with this is that the definition of ubuntu-latest changed to now point to ubuntu-22.04. The published binary versions of airbyte-ci seem to be incompatible with the ubuntu we are using now. We tried rolling this back but it wasn't successful. The fix we found was to always use the Python-based installation of airbyte-ci - at least for now.

Note:

Vercel is still failing as of now. We will need to research this, most likely. In the meanwhile, this PR will at least unblock devs to work on connectors.

Org runners definitions (requires org admin permissions):

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ❌ Failed (Inspect) Jan 8, 2025 11:44pm

@aaronsteers
Copy link
Collaborator

Noting for visbility and future reference:

Failure still occured when we pre-run setup-python. Suspected cause is that binary for airbyte-ci needs gclib version that is not available or compatible with the new ubuntu runner.

Copy link
Collaborator

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/format-fix

@octavia-squidington-iii octavia-squidington-iii removed the area/documentation Improvements or additions to documentation label Jan 8, 2025
@octavia-squidington-iii octavia-squidington-iii removed the area/connectors Connector related issues label Jan 8, 2025
@aaronsteers aaronsteers changed the title test CI ci: fix failing airbyte-ci-install (related to ubuntu-latest image no longer compatible with airbyte-ci binaries) Jan 8, 2025
@ChristoGrab ChristoGrab marked this pull request as ready for review January 8, 2025 23:45
@ChristoGrab ChristoGrab requested a review from a team as a code owner January 8, 2025 23:45
@aaronsteers aaronsteers self-requested a review January 8, 2025 23:48
Copy link
Collaborator

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BAM! 💥

@aaronsteers aaronsteers merged commit 9573b99 into master Jan 8, 2025
26 of 27 checks passed
@aaronsteers aaronsteers deleted the christo/test-branch branch January 8, 2025 23:51
@johnnicely-cl
Copy link

johnnicely-cl commented Jan 9, 2025

For anyone else who's running into this issue outside of Github Actions: We're also running into this issue in Codebuild using the aws/codebuild/standard:7.0 image, which runs Ubuntu 22.04. We were able to fix by installing via Python, same as this PR. Any ideas on if there will be a fix for the binary installation method?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants